Update ZisK to `0.16.0` by han0110 · Pull Request #296 · eth-act/ere

han0110 · 2026-02-19T15:53:31Z

Update zisk to v0.16.0. Resolves Update zisk to v0.16.0 #308
- Patch is still needed, the diff can be found 0xPolygonHermez/zisk@v0.16.0...han0110:patch/v0.16.0, by commits:
  - han0110/zisk@8e5b3ee - Set complete for the ASM service so there is no dangling threads that causes memory leak, without this the prover restart will end up out of memory
  - han0110/zisk@44cd694 - Allow passing data from client, previously the data must be in path accessible by the coordinator
  - han0110/zisk@2152468 - Add gRPC endpoint SubscribeToProof to allow subscribe to proof completion/failure update, previously it only supports webhook
  - han0110/zisk@61fe439 - Disable local request check, previously it only allows request from localhost
Use zisk-sdk instead of using cargo-zisk. Resolves Use ZisK's SDK #73
- No need to setup explicitly, the prover now runs setup automatically if it's setup yet
- Use local prover instead of server, recovery from failure by cleaning up ASM services manually
Add stock rust Compiler impl RustRv64ima with target spec as json (supercedes Add rust stock compiler. #107, which has ZisK's stock rust compiler left unmerged)

han0110 · 2026-03-17T10:47:15Z

crates/test-utils/src/host.rs

        let digest = D::digest(P::Io::serialize_output(&output).unwrap());
-        assert_eq!(&*digest, public_values)
+        assert_eq!(&*digest, &public_values[..digest.len()]);
+        assert!(public_values[digest.len()..].iter().all(|byte| *byte == 0));


Because ZisK now outputs fixed 256 bytes public values, so here we check the rest of the bytes to be zero.

han0110 · 2026-03-17T10:49:21Z

crates/zkvm/zisk/src/zkvm/sdk/local.rs

+    }
+}
+
+fn assembly_files_exist(elf_hash: Hash) -> bool {


Inlined the ASM files existence check because the exported function requires a ELF path.

han0110 · 2026-03-17T10:50:36Z

crates/zkvm/zisk/src/zkvm/sdk/local.rs

+    let _ = Command::new("fuser")
+        .args(["-k", "-9", "23115/tcp", "23116/tcp", "23117/tcp"])
+        .output();
+    sleep(Duration::from_secs(1));


Forcely remove the process to make sure recovery from ASM services panic.

han0110 · 2026-03-17T10:51:37Z

crates/zkvm/zisk/src/zkvm/sdk.rs

+/// Merkle root of ROM trace.
+pub type ProgramVk = [u8; 32];


Renamed from RomDigest, ZisK calls the value ProgramVk now

han0110 · 2026-03-17T10:53:13Z

crates/zkvm/zisk/src/zkvm/sdk.rs

-    }
-
-    info!("Command `cargo-zisk check-setup --aggregation` succeeded");
+fn compute_program_vk(elf: &[u8]) -> Result<ProgramVk, Error> {


Inlined the cargo-zisk rom-setup because there is no method exported to do so directly

han0110 · 2026-03-17T10:55:07Z

crates/zkvm/zisk/src/zkvm/sdk.rs

+        let mut aligned = ManuallyDrop::new(vec![0u64; data.len() / 8]);
+        bytemuck::cast_slice_mut(&mut aligned).copy_from_slice(&data);
+        let ptr = aligned.as_mut_ptr().cast::<u8>();
+        let len = aligned.len() * size_of::<u64>();
+        let cap = aligned.capacity() * size_of::<u64>();
+        // SAFETY: `ptr` came from a `Vec<u64>` allocation.
+        unsafe { Vec::from_raw_parts(ptr, len, cap) }


Previously the way (to_vec()) actually doesn't guarantee the bytes to be aligned, so here we need to use Vec::from_raw_parts with ManuallyDrop to make sure the alignment is preserved.

han0110 · 2026-03-17T10:56:02Z

crates/zkvm/zisk/src/zkvm/sdk.rs

+/// Returns `data` with a LE u64 length prefix and padding to multiple of 8.
+///
+/// The length prefix and padding is expected by ZisK emulator/prover runtime.
+fn length_prefixed_and_padded(data: &[u8]) -> Vec<u8> {


Now ZisK requires input to be prefixed with u64 LE length, and padded to multiple of 8

han0110 · 2026-03-17T10:57:54Z

crates/zkvm/zisk/src/zkvm.rs

    CommonError, Input, ProgramExecutionReport, ProgramProvingReport, Proof, ProofKind,
    ProverResource, PublicValues, zkVM, zkVMProgramDigest,
 };
+use mpi as _; // Import symbols referenced by starks_api.cpp


To run the rom_merkle_setup we have to initialize the MpiCtx, however if mpi is enabled it the MpiCtx can't be initialized twice, so we disable the mpi feature by disable_distributed.

However, there is still some code references the mpi symbols, so here we still need to import it..

han0110 · 2026-03-17T11:08:48Z

crates/test-utils/src/program/basic.rs

+            c: input.c.wrapping_mul(input.a as u32).wrapping_add(1),
+            d: input.d.wrapping_mul(input.b as u64).wrapping_add(1),


ZisK prover panics when some AIR has empty trace, so here we add some multiplication operation

jsign

LGTM! Left some nit comments/questions.

crates/zkvm/openvm/src/zkvm.rs

crates/zkvm/zisk/src/zkvm/error.rs

jsign · 2026-03-17T14:15:10Z

crates/zkvm/zisk/src/zkvm/sdk/local.rs

+fn uninitialize(mut prover_and_pk: MutexGuard<Option<(ZiskProver<Asm>, ZiskProgramPK)>>) {
+    info!("Uninitializing ZisK prover...");
+
+    let _ = Command::new("fuser")


Creative :P

han0110 force-pushed the han/feature/zisk-v0.16.0 branch 3 times, most recently from a2e9c52 to a3bbf87 Compare February 26, 2026 14:56

han0110 force-pushed the han/feature/zisk-v0.16.0 branch from a3bbf87 to e55bb73 Compare March 2, 2026 17:38

han0110 force-pushed the han/feature/zisk-v0.16.0 branch from e55bb73 to 14d7003 Compare March 13, 2026 14:05

han0110 changed the title ~~[WIP] Update ZisK to 0.16.0~~ Update ZisK to 0.16.0 Mar 17, 2026

han0110 force-pushed the han/feature/zisk-v0.16.0 branch 2 times, most recently from f5213da to d936d54 Compare March 17, 2026 09:13

han0110 marked this pull request as ready for review March 17, 2026 10:31

feat: add Compiler impl RustRv64ima in ere-zisk

37e0024

han0110 force-pushed the han/feature/zisk-v0.16.0 branch from d936d54 to bc7040e Compare March 17, 2026 10:44

han0110 commented Mar 17, 2026

View reviewed changes

han0110 added 6 commits March 17, 2026 14:09

feat: use zisk-sdk at patched `v0.16.0

3bf8eae

feat: make test guest have mul operation

35ab8e2

chore: udpate README.md

d693354

feat: add gpu prove test and invalid test case recovery for all zkvms

c1fd69e

ci: set test threads to 1 for jolt

defe342

chore: remove unused deps

fa3983b

han0110 force-pushed the han/feature/zisk-v0.16.0 branch from bc7040e to fa3983b Compare March 17, 2026 14:09

jsign approved these changes Mar 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ZisK to `0.16.0`#296

Update ZisK to `0.16.0`#296
han0110 wants to merge 7 commits intomasterfrom
han/feature/zisk-v0.16.0

han0110 commented Feb 19, 2026 •

edited

Loading

Uh oh!

han0110 Mar 17, 2026

Uh oh!

han0110 Mar 17, 2026

Uh oh!

han0110 Mar 17, 2026

Uh oh!

han0110 Mar 17, 2026

Uh oh!

han0110 Mar 17, 2026

Uh oh!

han0110 Mar 17, 2026

Uh oh!

han0110 Mar 17, 2026

Uh oh!

han0110 Mar 17, 2026

Uh oh!

han0110 Mar 17, 2026

Uh oh!

jsign left a comment

Uh oh!

Uh oh!

Uh oh!

jsign Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		c: input.c.wrapping_mul(input.a as u32).wrapping_add(1),
		d: input.d.wrapping_mul(input.b as u64).wrapping_add(1),

Conversation

han0110 commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsign left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

han0110 commented Feb 19, 2026 •

edited

Loading